fix: move VAULT_ENV_FROM_PATH to mutateContainers #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocpatel
force-pushed
the
fix-env-from-path
branch
from
42146e3
to
9364538
Compare
rrondeau
pushed a commit
to rrondeau/bank-vaults
that referenced
this pull request
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
When adding the env-from-path annotation, I was incorrectly mutating the pod instead of the container. This fix is to actually mutate the container. The work around for this is to explicitly add
VAULT_ENV_FROM_PATHenvironment variable to the container.Checklist