Add support for GCR default credentials #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
viktorradnai
force-pushed
the
webhook-gcr-support
branch
from
4273a29
to
45a5340
Compare
bonifaido
reviewed
Sep 25, 2020
| @@ -52,6 +55,9 @@ func init() { | |||
|
|
|||
| // Adapted from https://github.com/awslabs/amazon-ecr-credential-helper/blob/master/ecr-login/api/client.go#L34 | |||
| ecrHostPattern = regexp.MustCompile(`([a-zA-Z0-9][a-zA-Z0-9-_]*)\.dkr\.ecr(\-fips)?\.([a-zA-Z0-9][a-zA-Z0-9-_]*)\.amazonaws\.com(\.cn)?`) | |||
|
|
|||
| // From https://cloud.google.com/container-registry/docs/overview | |||
| gcrHostPattern = regexp.MustCompile(`((us|eu|asia)\.)?gcr.io`) | |||
There was a problem hiding this comment.
Code scanning just gave some hints here about the unescaped dot, which is highly unlikely to cause any issues, but we probably should escape it ;)
bonifaido
previously approved these changes
Sep 25, 2020
There was a problem hiding this comment.
LGTM, other than the small code scanning hint. Thank you @viktorradnai !
|
Once this gets merged, we should add it to the docs, that this works automatically for GCR as well here: https://github.com/banzaicloud/bank-vaults-docs/blob/12b992e5262acad355767a72371d3449a408960a/docs/mutating-webhook/_index.md#registry-access |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR adds support for authenticating against Google Container Registry without explicit username / password.
It works similarly to the already present Amazon ECR support: If there are no username / password / imagePullSecrets specified, then it checks the registry hostname against the known GCR hotsts. If the pattern matches then it tries to obtain an auth token from the metadata service endpoint when running inside Google Cloud (which also works with workload identity if running in GKE).
Why?
Using default credentials avoids the need for pre-shared credentials (passwords or manually generated service account tokens) which would need to be managed.
Additional context
Checklist
To Do
This PR does not address authenticating with an user supplied Google service account token (although that may be possible using the username/password mechanism but was not tested).