Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook: change the resource limit/requests of copy-vault-env and vault-agent to a sane value #1124

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

bonifaido
Copy link
Member

@bonifaido bonifaido commented Sep 30, 2020

Signed-off-by: Nandor Kracser bonifaido@gmail.com

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
Related tickets fixes #940
License Apache 2.0

What's in this PR?

Increasing the CPU limits and defining a proper CPU request for some init containers.

Why?

The copy-vault-env and vault-agent init containers are starving on throttled hosts.

Additional context

Checklist

@bonifaido bonifaido self-assigned this Sep 30, 2020
@bonifaido bonifaido added webhook kind/enhancement Categorizes issue or PR as related to an improvement. labels Sep 30, 2020
…lt-agent to a sane value

Signed-off-by: Nandor Kracser <bonifaido@gmail.com>
@bonifaido bonifaido marked this pull request as ready for review September 30, 2020 13:04
@bonifaido bonifaido changed the title webhook: increase the cpu limit of copy-vault-env to a more valid value webhook: change the resource limit/requests of copy-vault-env and vault-agent to a sane value Sep 30, 2020
@bonifaido bonifaido merged commit b72528c into master Sep 30, 2020
@bonifaido bonifaido deleted the copy-vault-env branch September 30, 2020 13:40
rrondeau pushed a commit to rrondeau/bank-vaults that referenced this pull request Nov 3, 2020
…lt-agent to a sane value (bank-vaults#1124)

Signed-off-by: Nandor Kracser <bonifaido@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes issue or PR as related to an improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Being able to set resource limits on injected "copy-vault-env"
2 participants