cli: handle signals properly #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/bank-vaults/main.go
Outdated
| @@ -99,6 +101,16 @@ var rootCmd = &cobra.Command{ | |||
| // Execute adds all child commands to the root command sets flags appropriately. | |||
| // This is called by main.main(). It only needs to happen once to the rootCmd. | |||
| func execute() { | |||
| // Handle signals to prevent bad exit codes on `docker stop`. | |||
| // TODO: robably a more sophisticated exit procedure should be implemented in the future. | |||
There was a problem hiding this comment.
Suggested change
| // TODO: robably a more sophisticated exit procedure should be implemented in the future. | |
| // TODO: probably a more sophisticated exit procedure should be implemented in the future. |
There was a problem hiding this comment.
Yeah, that's not a bad idea. :D
cmd/bank-vaults/main.go
Outdated
| sigs := make(chan os.Signal, 1) | ||
| signal.Notify(sigs, syscall.SIGTERM, syscall.SIGINT, syscall.SIGABRT) | ||
| go func() { | ||
| for range sigs { |
There was a problem hiding this comment.
No need for for. <-sigs should work.
Signed-off-by: Nandor Kracser <bonifaido@gmail.com>
pbalogh-sa
approved these changes
Oct 2, 2020
sagikazarmark
approved these changes
Oct 2, 2020
rrondeau
pushed a commit
to rrondeau/bank-vaults
that referenced
this pull request
Nov 3, 2020
Signed-off-by: Nandor Kracser <bonifaido@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nandor Kracser bonifaido@gmail.com
What's in this PR?
Handling signals, and do a 0 status code exit.
Why?
If signals are not captured the CLI exits with status code 2.
Additional context
Checklist