Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom fluentd conf path #1134

Merged
merged 2 commits into from
Oct 6, 2020

Conversation

idgenchev
Copy link
Contributor

@idgenchev idgenchev commented Oct 5, 2020

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets fixes #1135
License Apache 2.0

What's in this PR?

Enable setting custom path for fluent.conf

Why?

We are using a custom fluentd image that expects fluent.conf to be under /etc/fluent/ and we need a way to customise it.

Additional context

Checklist

  • [ Y ] Code meets the Developer Guide
  • [ Y ] User guide and development docs updated (if needed)
  • [ Y ] Related Helm chart(s) updated (if needed)

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@bonifaido bonifaido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM @idgenchev Thanks!

@bonifaido bonifaido self-assigned this Oct 6, 2020
@bonifaido bonifaido merged commit 0d4d11a into bank-vaults:master Oct 6, 2020
rrondeau pushed a commit to rrondeau/bank-vaults that referenced this pull request Nov 3, 2020
* Enable setting custom path for fluent.conf

* Update deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting a custom path for fluent.conf
3 participants