operator: drop helm2 support in the chart

[bonifaido]

Signed-off-by: Nandor Kracser bonifaido@gmail.com

Q	A
Bug fix?	yes
New feature?	no
API breaks?	no
Deprecations?	yes
Related tickets	fixes #1059, fixes #1097
License	Apache 2.0

What's in this PR?

Dropping Helm 2 support in the operator chart. We keep the compatibility in the other charts for a while, but officially we are not supporting Helm 2 from now on.

Why?

Helm 2 is reaching the end of life this month, and we had a hacky helper template which caused some issues in Helm linters.

Additional context

Helm2 -> Helm3 migration

If you have installed the chart with Helm 2 and now you are trying to upgrade it with Helm3 you have to be careful because Helm 3 will delete the Vault CRD from your cluster during the upgrade from Helm 2 (see helm/helm#7279). To avoid that follow these steps:

# Make sure you are using Helm 3
helm version

# version.BuildInfo{Version:"v3.3.4", GitCommit:"a61ce5633af99708171414353ed49547cf05013d", GitTreeState:"clean", GoVersion:"go1.14.9"}

# Get the latest vault-operator chart
helm repo add banzaicloud-stable https://kubernetes-charts.banzaicloud.com
helm repo update

# Delete all Helm2 releases of the vault-operator manually wit kubectl to keep the resources in the cluster
kubectl delete configmaps -n kube-system vault-operator.v1
# Delete all resources except the Vault CRD
helm template vault-operator banzaicloud-stable/vault-operator | kubectl delete -f -
# Install the new Helm3 version of the chart
helm upgrade --install vault-operator banzaicloud-stable/charts/vault-operator

Checklist

• Code meets the Developer Guide
• User guide and development docs updated (if needed)
• Related Helm chart(s) updated (if needed)