Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vault agent -once command to exit after auth #1168

Merged
merged 2 commits into from Oct 30, 2020
Merged

fix vault agent -once command to exit after auth #1168

merged 2 commits into from Oct 30, 2020

Conversation

joshdvir
Copy link
Contributor

@joshdvir joshdvir commented Oct 30, 2020

Q A
Bug fix Yes
New feature no
API breaks no
Deprecations no
Related tickets none
License Apache 2.0

What's in this PR?

This PR fixes the command passing the vault agent command to exit after the auth process.

Why?

vault agent command doesn't support the current -once attribute, the correct attribute is -exit-after-auth

Checklist

@CLAassistant
Copy link

CLAassistant commented Oct 30, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@bonifaido bonifaido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment ☝️

@bonifaido bonifaido self-assigned this Oct 30, 2020
@joshdvir
Copy link
Contributor Author

@bonifaido fixed, thanks!

Copy link
Member

@bonifaido bonifaido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@bonifaido bonifaido merged commit cb87e61 into bank-vaults:master Oct 30, 2020
rrondeau pushed a commit to rrondeau/bank-vaults that referenced this pull request Nov 3, 2020
…lts#1168)

* vault agent command to exit after auth

* change in the wrong place
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants