allow the vault-webhook to be contacted over loadbalancer or ingress #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bonifaido
approved these changes
Nov 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
MutatingWebhook can also connect to an url. Currently this can only be an (k8s) service. This PR add the ability to create
a k8s Loadbalancer or k8s Ingress and use the url method
Why?
Using the Service method can cause the webhook to be temporary unreachable. Check the following issues
kubernetes/kubernetes#80313
kubernetes/client-go#374 (comment)
In short, the client-go library caches the ip of the pod so if the pod gets an different ip the cache needs to invalidate
which takes time. Using a url instead of the service is a workaround until this is fixed in k8s.
Checklist
To Do