vault-secrets-webhook: Allow users to specify resources for init-containers #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…init-containers vault-env and copy-vault-env from environment variables VAULT_ENV_CPU_REQUEST, VAULT_ENV_MEMORY_REQUEST, VAULT_ENV_CPU_LIMIT, VAULT_ENV_MEMORY_LIMIT
|
|
sopriani
changed the title
sopriani
changed the title
pbalogh-sa
reviewed
May 20, 2021
There was a problem hiding this comment.
Thanks @sopriani ! Please bump the vault-secrets-webhook chart version, otherwise LGTM.
|
Can you fix the tests? You can check it in the build logs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Introduced environment variables ( VAULT_ENV_CPU_REQUEST, VAULT_ENV_MEMORY_REQUEST, VAULT_ENV_CPU_LIMIT, VAULT_ENV_MEMORY_LIMIT) for vault-secrets-webhook. Instead of applying hard-coded values, this provides the users an option to specify resource requests and limits for the init-containers being added during pod mutation for secrets viz vault-env and copy-vault-env. Without this change, it is not possible to run mutated pods with "guaranteed" QoS using the default settings - they always run with "burstable".
Hint: Set VAULT_ENV_CPU_LIMIT=50m to be able to run the mutated pod with guaranteed QoS.
Checklist