Set Vault Namespace on underlying rawClient if it has a non-empty value #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
We have some compile errors now. Could you please have a look @wmene ? |
|
@bonifaido Whoops, sorry about that. First time working with golang, but things should be ok now |
|
@bonifaido Thanks for looking! It looks like I just missed the 1.14.0 release. Any idea about when 1.14.1 or later will come out? 😀 |
|
I think we wait for a few more items usually 1 or 2 weeks :) |
|
Releasing in 1 hour from now. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This completes the work in PR #1361 . This enables mutation of non-pod resources like secrets. It sets the vault namespace on the underlying
rawClientused in pkg/sdk/vault/client.goWhy?
Even though PR #1361 parses out
vault-namespacefrom a resource's annotation, it does not set that value on the underlying vault client.Additional context
As described in #917, this is not an issue for pods that set the
VAULT_NAMESPACEenvironment variable. Setting this environment variable does get picked up by the client, see https://github.com/hashicorp/vault/blob/v1.8.2/api/client.go#L484Checklist