Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API versions for k8s < 1.21 #1413

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

horjulf
Copy link
Contributor

@horjulf horjulf commented Sep 9, 2021

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

This fixes chart deployment in clusters with version < 1.21 due to breaking change introduced at https://github.com/banzaicloud/bank-vaults/pull/1404.

Why?

Additional context

Happy to do the same changes in the Vault chart if all looks good.

Checklist

@CLAassistant
Copy link

CLAassistant commented Sep 9, 2021

CLA assistant check
All committers have signed the CLA.

@bonifaido bonifaido self-assigned this Sep 9, 2021
Copy link
Member

@bonifaido bonifaido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this fix, I haven't noticed this API is only since 1.21 sorry for that!

@bonifaido bonifaido merged commit d03bedf into bank-vaults:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants