Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed replicaset and deployment RBAC issues for Kubernetes < 1.6 #752

Merged
merged 4 commits into from
Nov 19, 2019
Merged

Fixed replicaset and deployment RBAC issues for Kubernetes < 1.6 #752

merged 4 commits into from
Nov 19, 2019

Conversation

szwed
Copy link
Contributor

@szwed szwed commented Nov 18, 2019

replicaset and deployment objects in earlier Kubernetes versions were put under extensions/ api group not /apps, this causes the following errors:

"error":"failed to initialize service object for metrics: deployments.extensions \"vault-operator\" is forbidden
"error":"failed to initialize service object for metrics: replicasets.extensions \"vault-operator-588dcd9cb6\" is forbidden:

Official documentation:
https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16

I think it is better to support both as it is a blocker in many older environments.

TEST:

(⎈ |minikube:default)MacBook-Pro-Piotr:charts piotrszwed$ kubectl get clusterrole solemn-crocodile-vault-operator -o yaml | grep -C 3 extensions |head -n 17
  - watch
- apiGroups:
  - apps
  - extensions
  resources:
  - replicasets
  verbs:
--
--
  - get
- apiGroups:
  - apps
  - extensions
  resources:
  - deployments
  - deployments/finalizers

Deployoment log (K8s version: v1.10.11):

{"level":"info","ts":1574083565.3331227,"logger":"cmd","msg":"Go Version: go1.13.4"}
{"level":"info","ts":1574083565.3331542,"logger":"cmd","msg":"Go OS/Arch: linux/amd64"}
{"level":"info","ts":1574083565.333161,"logger":"cmd","msg":"operator-sdk Version: v0.9.0"}
{"level":"info","ts":1574083565.3331723,"logger":"cmd","msg":"Watched namespace: "}
{"level":"info","ts":1574083565.333361,"logger":"leader","msg":"Trying to become the leader."}
{"level":"info","ts":1574083565.3334296,"logger":"cmd","msg":"Liveness probe listening on: 8080"}
{"level":"info","ts":1574083565.6366625,"logger":"leader","msg":"Found existing lock","LockOwner":"vault-operator-588dcd9cb6-p96ct"}
{"level":"info","ts":1574083565.7318213,"logger":"leader","msg":"Not the leader. Waiting."}
{"level":"info","ts":1574083566.8630428,"logger":"leader","msg":"Not the leader. Waiting."}
{"level":"info","ts":1574083569.2516124,"logger":"leader","msg":"Not the leader. Waiting."}
{"level":"info","ts":1574083573.795136,"logger":"leader","msg":"Not the leader. Waiting."}
{"level":"info","ts":1574083582.5146194,"logger":"leader","msg":"Not the leader. Waiting."}
{"level":"info","ts":1574083599.8892796,"logger":"leader","msg":"Not the leader. Waiting."}
{"level":"info","ts":1574083618.1314929,"logger":"leader","msg":"Became the leader."}
{"level":"info","ts":1574083618.2411208,"logger":"cmd","msg":"Registering Components."}
{"level":"info","ts":1574083618.450069,"logger":"kubebuilder.controller","msg":"Starting EventSource","controller":"vault-controller","source":"kind source: /, Kind="}
{"level":"info","ts":1574083618.6927426,"logger":"metrics","msg":"Metrics Service object created","Service.Name":"vault-operator-metrics","Service.Namespace":"vault-stage"}
{"level":"info","ts":1574083618.6927688,"logger":"cmd","msg":"Starting the Cmd."}
{"level":"info","ts":1574083618.831376,"logger":"kubebuilder.controller","msg":"Starting Controller","controller":"vault-controller"}
{"level":"info","ts":1574083618.931717,"logger":"kubebuilder.controller","msg":"Starting workers","controller":"vault-controller","worker count":1}

@bonifaido bonifaido self-assigned this Nov 18, 2019
Copy link
Member

@bonifaido bonifaido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bonifaido bonifaido merged commit c46e59e into bank-vaults:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants