Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: add vault condition statuses #972

Merged
merged 3 commits into from
May 8, 2020
Merged

Conversation

bonifaido
Copy link
Member

@bonifaido bonifaido commented May 7, 2020

Signed-off-by: Nandor Kracser bonifaido@gmail.com

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets fixes #971
License Apache 2.0

What's in this PR?

Write standard Kubernetes Condition status to the Vault CR instance.

Why?

To be able to wait for healthy vault instance from deployments.

Additional context

Can Vault CR status now can be tested with:

kubectl wait --for=condition=Healthy vault/vault

Checklist

  • Error handling code meets the guideline
  • Logging code meets the guideline (TODO)

Signed-off-by: Nandor Kracser <bonifaido@gmail.com>
Signed-off-by: Nandor Kracser <bonifaido@gmail.com>
@bonifaido bonifaido added kind/enhancement Categorizes issue or PR as related to an improvement. operator labels May 7, 2020
@bonifaido bonifaido requested a review from baluchicken May 7, 2020 14:35
@bonifaido bonifaido self-assigned this May 7, 2020
@bonifaido bonifaido requested a review from pbalogh-sa May 8, 2020 11:46
@bonifaido bonifaido marked this pull request as ready for review May 8, 2020 11:46
Copy link
Contributor

@baluchicken baluchicken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also regenerate the CRDs as well.

operator/pkg/apis/vault/v1alpha1/vault_types.go Outdated Show resolved Hide resolved
@bonifaido
Copy link
Member Author

Please also regenerate the CRDs as well.

@baluchicken yes, I will once https://github.com/banzaicloud/bank-vaults/issues/769 is implemented, I will prioritize it for next week! Thanks!

@bonifaido bonifaido merged commit 2705c40 into master May 8, 2020
@bonifaido bonifaido deleted the vault-condition-status branch May 8, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes issue or PR as related to an improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wait condition for Vault Custom Resource
3 participants