webhook: support cert renewal in bods by using secret projectedVolume instead of subPath mounts #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nandor Kracser <bonifaido@gmail.com>
Signed-off-by: Nandor Kracser <bonifaido@gmail.com>
bonifaido
requested review from
pbalogh-sa and
baluchicken
and removed request for
pbalogh-sa
bonifaido
changed the title
pepov
approved these changes
May 12, 2020
bonifaido
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Using projected volumes to mount CA secrets into pods in the webhook.
Why?
Because when the secret gets modified and the pod restarts it won't work again, see: kubernetes/kubernetes#68211
Additional context
This is an upstream Kubernetes issue that is not fixed for a long time, but we can work around it locally here.
Checklist