webhook: allow to pass data in write request #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonifaido
force-pushed
the
webhook-write-data
branch
from
cc044a2
to
b39130f
Compare
Signed-off-by: Nandor Kracser <bonifaido@gmail.com>
Signed-off-by: Nandor Kracser <bonifaido@gmail.com>
Signed-off-by: Nandor Kracser <bonifaido@gmail.com>
Signed-off-by: Nandor Kracser <bonifaido@gmail.com>
Signed-off-by: Nandor Kracser <bonifaido@gmail.com>
bonifaido
force-pushed
the
webhook-write-data
branch
from
4c751b0
to
de9f363
Compare
Signed-off-by: Nandor Kracser <bonifaido@gmail.com>
Signed-off-by: Nandor Kracser <bonifaido@gmail.com>
bonifaido
added
the
kind/enhancement
Signed-off-by: Nandor Kracser <bonifaido@gmail.com>
bonifaido
force-pushed
the
webhook-write-data
branch
from
7344483
to
eaa7ea4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nandor Kracser bonifaido@gmail.com
What's in this PR?
Design and implement the sending of write parameters and document the feature with examples.
Why?
It is already possible to request dynamic secrets from Vault with "write" requests.
However, this feature is undeservedly underdocumented and incomplete since it is not possible to add data to those write requests.
Additional context
Checklist