[chart/webhook] fix Kubernetes version comparison #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
martinezleoml
force-pushed
the
fix-semver-compare
branch
from
12db3f2
to
db31fcb
Compare
|
@martinezleoml Thanks for the contribution. Could you be so kind as to rebase to the master? Otherwise LGTM. |
Signed-off-by: Léo Martinez <leo84.martinez@gmail.com>
martinezleoml
force-pushed
the
fix-semver-compare
branch
from
db31fcb
to
3637202
Compare
Thanks for reviewing. |
bonifaido
approved these changes
May 18, 2020
pbalogh-sa
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This uses
semverComparehelm template function instead of integer when comparing Kubernetes version.It fixes #986.
Why?
Using
.Capabilities.KubeVersion.Majorand.Capabilities.KubeVersion.Minoris error prone as the value may not always be integer values (like it's the case of some managed Kubernetes offers as AWS EKS).Additional context
Checklist
To Do