Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve lint and introduce emperror errors #989

Merged
merged 1 commit into from
May 20, 2020
Merged

Conversation

bonifaido
Copy link
Member

@bonifaido bonifaido commented May 19, 2020

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
Related tickets fixes #334
License Apache 2.0

What's in this PR?

Why?

Additional context

Checklist

  • Error handling code meets the guideline
  • Logging code meets the guideline (TODO)

@bonifaido bonifaido changed the title Improve lint Improve lint and introduce emperror errors May 19, 2020
@bonifaido bonifaido force-pushed the improve-lint branch 4 times, most recently from 875ed72 to 4786c8c Compare May 20, 2020 08:51
@bonifaido bonifaido self-assigned this May 20, 2020
Signed-off-by: Nandor Kracser <bonifaido@gmail.com>
@bonifaido bonifaido marked this pull request as ready for review May 20, 2020 10:32
@bonifaido bonifaido requested a review from pbalogh-sa May 20, 2020 10:33
@bonifaido bonifaido merged this pull request into master May 20, 2020
@bonifaido bonifaido deleted the improve-lint branch May 20, 2020 10:40
bonifaido added a commit that referenced this pull request May 20, 2020
Signed-off-by: Nandor Kracser <bonifaido@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use emperror for proper error handling
2 participants