Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCP 4.3: runAsUser in Vault Secrets webhook chart should be configurable #995

Merged
merged 1 commit into from
May 27, 2020
Merged

OCP 4.3: runAsUser in Vault Secrets webhook chart should be configurable #995

merged 1 commit into from
May 27, 2020

Conversation

dakine1111
Copy link
Contributor

The userid 65534 is not an allowed user in openshift.

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets fixes #994
License Apache 2.0

What's in this PR?

Add the ability to use a custom runAsUser in the helm chart.

Why?

When using the vault secrets webhook chart in OCP 4.3.x for security reasons the runAsUser must be in the range between 1000570000 and 1000579999 and not 65534.

Checklist

  • Code meets the Developer Guide
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

@CLAassistant
Copy link

CLAassistant commented May 27, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@bonifaido
Copy link
Member 

Error linting charts: Error processing charts
------------------------------------------------------------------------------------------------------------------------
 ✖︎ vault-secrets-webhook => (version: "1.2.2", path: "charts/vault-secrets-webhook") > Chart version not ok. Needs a version bump!

@bonifaido bonifaido self-assigned this May 27, 2020
@dakine1111
OCP 4.3: runAsUser in Vault Secrets webhook chart should be configurable
b220644 
The userid 65534 is not an allowed user in openshift.
bonifaido
bonifaido approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@bonifaido bonifaido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @dakine1111

pbalogh-sa
pbalogh-sa approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@pbalogh-sa pbalogh-sa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bonifaido bonifaido merged commit 150b4c1 into bank-vaults:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonifaido bonifaido bonifaido approved these changes

@pbalogh-sa pbalogh-sa pbalogh-sa approved these changes

Assignees

@bonifaido bonifaido

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OCP 4.3: runAsUser in Vault Secrets webhook chart should be configurable
4 participants
@dakine1111 @CLAassistant @bonifaido @pbalogh-sa