Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we need to convert CSV reader to a list? #29

Closed
nocalla opened this issue Oct 20, 2017 · 1 comment
Closed

Do we need to convert CSV reader to a list? #29

nocalla opened this issue Oct 20, 2017 · 1 comment
Assignees
@nocalla
Labels
bug enhancement

Comments

@nocalla
Copy link
Member

nocalla commented Oct 20, 2017

I can't remember my logic for the list(transaction_reader) line that's causing trouble in issue #12. Going to experiment with removing it.
@nocalla nocalla self-assigned this Oct 20, 2017
nocalla added a commit to nocalla/bank2ynab that referenced this issue Oct 21, 2017
@nocalla
Fix for issue bank2ynab#29
49f440b 
Looks like the answer to that question is "no". I have no idea why I did the conversion to list in the first place. This should improve memory efficiency.
nocalla added a commit to nocalla/bank2ynab that referenced this issue Oct 21, 2017
@nocalla
Fix issue bank2ynab#29 - no need to turn csv reader into list
ae819d5
nocalla added a commit to nocalla/bank2ynab that referenced this issue Oct 21, 2017
@nocalla
Remove conversion of csv to list, add IndexError exception handling
1011ad2 
This fixes issues bank2ynab#19 & bank2ynab#29 hopefully. Sorry about all prevous merge problems - accidentally merged to the wrong upstream source with the pull request and then tried to revert it...
@nocalla nocalla mentioned this issue Oct 21, 2017
Merged
@nocalla
Copy link
Member Author

nocalla commented Oct 22, 2017

Answer is no!

@nocalla nocalla closed this as completed Oct 22, 2017
This was referenced Oct 22, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nocalla nocalla

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nocalla