Skip to content

Commit

Permalink
* tests
Browse files Browse the repository at this point in the history
  • Loading branch information
ekho committed Jul 22, 2016
1 parent dcea88f commit 7c38801
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 1 deletion.
19 changes: 18 additions & 1 deletion spec/nginx-metrix/aggregator_spec.lua
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,24 @@ describe('nginx-metrix.aggregator', function()
end)

it('init', function()
pending('impelement it')
local storage_emu = { 'storage' }

aggregator._default_window_size = 17

aggregator.init({}, storage_emu)
assert.is_equal(storage_emu, aggregator._storage)
assert.is_equal(17, aggregator._default_window_size)

aggregator._default_window_size = nil
aggregator._storage = nil

aggregator.init({ default_window_size = 19 }, storage_emu)

assert.is_equal(storage_emu, aggregator._storage)
assert.is_equal(19, aggregator._default_window_size)

aggregator._default_window_size = nil
aggregator._storage = nil
end)

it('aggregate', function()
Expand Down
6 changes: 6 additions & 0 deletions spec/nginx-metrix_spec.lua
Original file line number Diff line number Diff line change
Expand Up @@ -31,18 +31,21 @@ describe('nginx-metrix', function()

stub(nginx_metrix, 'init_storage')
stub(nginx_metrix, 'init_vhosts')
stub(nginx_metrix, 'init_scheduler')
stub(nginx_metrix, 'init_builtin_collectors')
local options_emu = { some_option = 'some_value' }

nginx_metrix.init(options_emu)

assert.spy(nginx_metrix.init_storage).was_called_with(options_emu)
assert.spy(nginx_metrix.init_vhosts).was_called_with(options_emu)
assert.spy(nginx_metrix.init_scheduler).was_called_with(options_emu)
assert.spy(nginx_metrix.init_builtin_collectors).was_called_with(options_emu)
assert.is_true(nginx_metrix._inited)

nginx_metrix.init_storage:revert()
nginx_metrix.init_vhosts:revert()
nginx_metrix.init_scheduler:revert()
nginx_metrix.init_builtin_collectors:revert()
end)

Expand All @@ -51,6 +54,7 @@ describe('nginx-metrix', function()

stub(nginx_metrix, 'init_storage')
stub(nginx_metrix, 'init_vhosts')
stub(nginx_metrix, 'init_scheduler')
stub(nginx_metrix, 'init_builtin_collectors')

nginx_metrix.init_storage.on_call_with({}).invokes(function() error('init_storage error') end)
Expand All @@ -65,13 +69,15 @@ describe('nginx-metrix', function()
assert.spy(nginx_metrix.init_storage).was_called_with({})
assert.spy(nginx_metrix.init_storage).was_called(1)
assert.spy(nginx_metrix.init_vhosts).was_not_called()
assert.spy(nginx_metrix.init_scheduler).was_not_called()
assert.spy(nginx_metrix.init_builtin_collectors).was_not_called()
assert.spy(nginx_metrix._logger.err).was_called_with(nginx_metrix._logger, 'Init failed. Metrix disabled.', match.matches('init_storage error'))
assert.is_false(nginx_metrix._inited)

nginx_metrix._logger = logger_bak
nginx_metrix.init_storage:revert()
nginx_metrix.init_vhosts:revert()
nginx_metrix.init_scheduler:revert()
nginx_metrix.init_builtin_collectors:revert()
end)

Expand Down
1 change: 1 addition & 0 deletions src/nginx-metrix.lua
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ function M.init(options)
xpcall(function()
M.init_storage(options)
M.init_vhosts(options)
M.init_scheduler(options)
M.init_builtin_collectors(options)
M._inited = true
end,
Expand Down

0 comments on commit 7c38801

Please sign in to comment.