Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

認証処理の最適化 #1165

Merged
merged 8 commits into from
May 11, 2024
Merged

認証処理の最適化 #1165

merged 8 commits into from
May 11, 2024

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented May 11, 2024

Abstract

Why

Links

Checked

  • Analyticsのログを入れたか
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた

コメントを読むとuserChangesはidTokenがリフレッシュされたタイミングでもよばれるので、それは不要だと判断してsign-in,sign-out時のイベントだけ拾うようにした
@bannzai bannzai merged commit 8d11561 into main May 11, 2024
4 checks passed
@bannzai bannzai deleted the fix/function/sign_in branch May 11, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant