Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP fix pill sheet modified history #397

Merged
merged 14 commits into from
Oct 16, 2021

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Oct 15, 2021

Abstract

  • ピルシートを跨いだ場合の番号記録(27~1)番までの記録について考慮できていなかったので修正する
    • と思ったが、グループ自体の情報を持つ必要がありそうで、流石に保存するデータ量的に現実的じゃないと思い断念
  • 最低限のdiffだけ残して、過去の表示がおかしいやつ諦めるでも良いか。って思い直してdiffの計算式だけかいた
    • 表示がまだ
    • テストも書いた

@bannzai bannzai closed this Oct 15, 2021
@bannzai bannzai reopened this Oct 15, 2021
@bannzai bannzai marked this pull request as draft October 15, 2021 22:44
@bannzai
Copy link
Owner Author

bannzai commented Oct 15, 2021

まだ一応Reopenしておこ

@bannzai bannzai marked this pull request as ready for review October 16, 2021 01:09
@bannzai
Copy link
Owner Author

bannzai commented Oct 16, 2021

方向性を変えてシートを跨ぐ場合の表示を簡易的に変更する
履歴残すために一回マージ

@bannzai bannzai merged commit ba8ddb7 into main Oct 16, 2021
@bannzai bannzai deleted the fix/function/pill_sheet_modified_history branch October 16, 2021 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant