Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor naming of stream #428

Merged
merged 23 commits into from
Nov 13, 2021
Merged

refactor naming of stream #428

merged 23 commits into from
Nov 13, 2021

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Nov 13, 2021

Abstract

subscribe => stream に Rename

Why

勢いでつけたけど間違えているなあ。ってネーミングを痺れを切らして直した

Other

ついでに他の気になっている場所もRename

  • _canceller => _domainNameCanceller
  • _service => _domainNameService
  • _entity => _domainName

@bannzai bannzai merged commit e63df47 into main Nov 13, 2021
@bannzai bannzai deleted the refactor/naming/to_stream branch November 13, 2021 21:34
@bannzai bannzai changed the title refactor naming to stream refactor naming of stream Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant