Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustment UI for account cooperation screen #455

Merged
merged 15 commits into from
Jan 1, 2022

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Jan 1, 2022

Abstract

  • 設定画面からのアカウント設定画面のUIを調整
    • Apple ロゴのアイコンを消した
  • サインイン前は共通のシートを出すようにした
  • サインイン周りの文言を統一した

HIG 的に オフィシャルなアイコンのみの使用はOK。ただその場合は文言(サインインとか)つけるな。文言をつけるようならHIGで提案しているようなボタンの見た目で文言も統一。という方針と汲み取ってアイコンを消した。Apple ID の項目をタップした後は、元々違う場所で使っ値えた、ボタン形式のUIが出るボトムシートが出るようにした

Why

リジェクトされた

Your app offers Sign in with Apple as a login option but does not use the appropriate Sign in with Apple button design, placement, and/or user interface elements. Specifically:
- There should be no text associated with the buttons for any login option if your app uses the Apple logo as a button for Sign in with Apple.
Next Steps
Please revise the Sign in with Apple buttons in your app so that they are compliant with the App Store Review Guidelines and the Sign in With Apple Human Interface Guidelines.
Resources
For information on implementing Sign in with Apple in your app:
- Review Displaying Sign in with Apple Buttons if your sign in process happens in a browser.
- Review the Sign in with Apple Human Interface Guidelines for an overview of design and formatting recommendations for Sign in with Apple.

developer.apple.comdeveloper.apple.com
Introduction - Sign in with Apple - Human Interface Guidelines - Apple Developer
Learn about designing apps for Sign in with Apple.

@bannzai bannzai changed the title Fix account cooperatino flow Adjustment UI for account cooperation screen Jan 1, 2022
@bannzai bannzai merged commit e242411 into main Jan 1, 2022
@bannzai bannzai deleted the fix/ui/setting_account_cooperation branch January 1, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant