Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement reverting pill take #477

Merged
merged 48 commits into from
Jan 17, 2022
Merged

Implement reverting pill take #477

merged 48 commits into from
Jan 17, 2022

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Jan 15, 2022 •
edited
Loading

Abstract

ピルマークをタップして未服用にできる機能を実装

Why

Links

Checked

  • Analyticsのログを入れたか
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた
  • リリースノートを追加した

Manual Test

  • DBの値もチェック
    • ボタンの飲んでいないタップで一つ未服用にできる
    • ピルマークタップで未服用にできる
    • ピルシートを跨いだ未服用にできる
    • 未服用したい日付よりも後ろに休薬期間がある場合は、休薬期間を取り消す
    • 休薬機能中は未服用にできない
    • 1つだけ未服用にした場合の服用履歴
    • 複数未服用にした場合の服用履歴

@bannzai
♻️ rename function
b9d8cf9
@bannzai
📝 add pill mark state
fa3fa0e
@bannzai
♻️ Rename to showsCheckmarks
b1de241
@bannzai
♻️ rename to show ripple animations
5d4a73b
@bannzai
♻️ remove unnecessary default arguments
089b74c
@bannzai
📝 add pill sheet group
2a42585
@bannzai
♻️ drop pill mark
0a9ea13
@bannzai
♻️ refactor constructor
81f579d
@bannzai
♻️ Remove unnecessary optional
6031191
@bannzai
📝 fix comment
b231887
@bannzai
WIP implement revert taken
3fc5fcd
@bannzai
📝 add todo comment
489e2df
@bannzai
♻️ to nullable lastTakenNumber
5aba0d2
@bannzai
♻️ Replace to use pillSheet.isAllTaken
472ecd8
@bannzai
♻️ Rename to isBegining
e5b1769
@bannzai
♻️ Rename to isBegining
696df8e
@bannzai
♻️ Rename to todayPillIsAlreadyTaken
93990a9
@bannzai
📝 add comment and to nulalble
82d3d8f
@bannzai
📝 add utility property and assert
edacd1d
@bannzai
♻️ remove unnecessary code
8adc9a0
@bannzai
✨ implement revert function
a8fb6be
@bannzai
WIP fix revert pill
d3a69ef
@bannzai
♻️ Rename to displayPillTakeDate
7f8e2e9
@bannzai
♻️ Reolace to entity/pillSheet methdo
5afb306
@bannzai
♻️ Refactor using displayPillTakeDate
e7878a6
@bannzai
📝 add logic for rest durations
766b0f8
@bannzai
:sparkels: call revert taken
cc6c69a
@bannzai
🐛 fix calculated revert date
79d04a1
@bannzai
♻️ remove -1
7b4f601
@bannzai
📝 fix display revert pill number
290c20a
@bannzai bannzai merged commit fae767d into main Jan 17, 2022
@bannzai bannzai deleted the add/function/revert_taken_pill branch January 17, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@bannzai