Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor setting page and TabView #495

Merged
merged 28 commits into from
Feb 6, 2022
Merged

Refactor setting page and TabView #495

merged 28 commits into from
Feb 6, 2022

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Feb 5, 2022

Abstract

  • SettingPageの最初のデータ取得を並列化した
  • ついでにuseEffect使うようにした
  • useEffect使う過程でkeysを変えてないのにTabPageの切り替えでuseEffectが再度呼ばれていることが気づいた。原因調査するとTabViewの子供はタブの切り替えごとにWidgetが生成され直すらしい。なので AutomaticKeepAlive を hooks 経由で指定できるようにした

Why

Links

Checked

  • Analyticsのログを入れたか
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた
  • リリースノートを追加した

@bannzai
Copy link
Owner Author

bannzai commented Feb 6, 2022

なんかビルド通らなくなってしまったのでついでにFlutterもバージョンも上げよう

@bannzai bannzai merged commit 3254b87 into main Feb 6, 2022
@bannzai bannzai deleted the refactor/page/setting branch February 6, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant