Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wording for apple signin #497

Merged
merged 3 commits into from
Feb 7, 2022
Merged

Fix wording for apple signin #497

merged 3 commits into from
Feb 7, 2022

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Feb 7, 2022

Abstract

Apple IDでサインイン/Apple IDで登録だとダメで、Appleでサインイン/Appleで登録だとOKなので変更する

Why

リジェクトされた

Links

Checked

  • Analyticsのログを入れたか
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた
  • リリースノートを追加した

@bannzai bannzai merged commit 0af4e28 into main Feb 7, 2022
@bannzai bannzai deleted the fix/word/apple_sign branch February 7, 2022 04:45
@bannzai bannzai restored the fix/word/apple_sign branch February 7, 2022 04:45
@bannzai bannzai deleted the fix/word/apple_sign branch February 7, 2022 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant