Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color,Font に const つける #522

Merged
merged 5 commits into from
Feb 27, 2022
Merged

Color,Font に const つける #522

merged 5 commits into from
Feb 27, 2022

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Feb 27, 2022

Abstract

TextColor,Fontが軒並みfinalで宣言されていたので const で宣言し直す。その後に $ dart fix --apply をつける

Why

Links

Checked

  • Analyticsのログを入れたか
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた
  • リリースノートを追加した

@bannzai bannzai merged commit 264508a into main Feb 27, 2022
@bannzai bannzai deleted the refactor/color/to_const branch February 27, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant