Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix codegen #534

Merged
merged 10 commits into from
Mar 10, 2022
Merged

Bugfix codegen #534

merged 10 commits into from
Mar 10, 2022

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Mar 10, 2022

Abstract

#521 の対応のコード生成し忘れ

Why

DBに登録する時に setting.pillSheetTypesが[null,null,null]で登録されるようになっていた。このデータをfromJsonでシリアライズを試みた時にアプリ上でエラーが発生してユーザーがアプリを操作できなくなっていた

Links

Checked

  • Analyticsのログを入れたか
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた
  • リリースノートを追加した

@bannzai bannzai changed the title 🐚 flutter pub run build_runner build --delete-conflicting-outputs Bugfix codegen Mar 10, 2022
@bannzai bannzai force-pushed the bugfix/pill_sheet_category_type branch from 1e24d97 to 64be8a1 Compare March 10, 2022 21:23
@bannzai bannzai force-pushed the bugfix/pill_sheet_category_type branch from 64be8a1 to ce076c9 Compare March 10, 2022 21:40
@bannzai bannzai merged commit b21ec03 into main Mar 10, 2022
@bannzai bannzai deleted the bugfix/pill_sheet_category_type branch March 10, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant