Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default value for initial setting reminder time #569

Merged
merged 133 commits into from
Apr 21, 2022

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Apr 20, 2022

Abstract

InitialSettingでのデフォルトの時間を変更する

Why

  • 22:00台のユーザーが増えすぎて、その時間帯の通知の処理のコストが跳ね上がるので一時的にバラす

Links

Checked

  • Analyticsのログを入れたか
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた
  • リリースノートを追加した

@bannzai bannzai force-pushed the fix/value/initial_setting_reminder_time branch from 813e90a to f93e82c Compare April 20, 2022 23:32
@bannzai bannzai marked this pull request as ready for review April 21, 2022 00:01
@bannzai bannzai merged commit f5e66de into main Apr 21, 2022
@bannzai bannzai deleted the fix/value/initial_setting_reminder_time branch April 21, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant