Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #593

Merged
merged 6 commits into from
May 15, 2022
Merged

Bugfix #593

merged 6 commits into from
May 15, 2022

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented May 15, 2022

Abstract

ピルシートの集計関数が間違えていた。単純に過去のピルシートの合計値を使う部分は置き換える。休薬期間分も合計する部分が不要だった

Why

Links

Checked

  • 4日休薬して日付表示した場合に3日分日付が飛んでいる
  • 4日休薬して服用日数表示した場合に連番表示になっている

Checked

  • Analyticsのログを入れたか
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた
  • リリースノートを追加した

@bannzai bannzai force-pushed the bugfix/calculate_summarize branch from ca36a9b to 5a91ae4 Compare May 15, 2022 06:50
@bannzai bannzai merged commit 061b58e into main May 15, 2022
@bannzai bannzai deleted the bugfix/calculate_summarize branch May 15, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant