Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intent flag #595

Merged
merged 1 commit into from
May 19, 2022
Merged

Fix intent flag #595

merged 1 commit into from
May 19, 2022

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented May 19, 2022

Abstract

Android 12以降のOSでプッシュ通知が受け取れなくなっていた

Why

Links

Checked

  • Analyticsのログを入れたか
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた
  • リリースノートを追加した

@@ -22,7 +22,7 @@ public class PilllFirebaseMessagingService: FirebaseMessagingService() {
val mainActivityIntent = Intent(this, MainActivity::class.java).also {
it.flags = Intent.FLAG_ACTIVITY_NEW_TASK
}
val openAppPendingIntent = PendingIntent.getActivity(this,1, mainActivityIntent, PendingIntent.FLAG_CANCEL_CURRENT)
val openAppPendingIntent = PendingIntent.getActivity(this, 1, mainActivityIntent, PendingIntent.FLAG_IMMUTABLE)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PendingIntentのフラグはFLAG_IMMUATBLEにする必要があった

ref: https://star-zero.medium.com/pendingintent%E3%81%AEflag-immutable%E3%81%A8flag-mutable-d72bf7c90135

@bannzai bannzai merged commit bd7c2a2 into main May 19, 2022
@bannzai bannzai deleted the bugfix/notification/android2 branch May 19, 2022 21:07
@bannzai bannzai mentioned this pull request May 19, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant