Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement generate debug info #602

Merged
merged 5 commits into from
May 30, 2022
Merged

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented May 30, 2022

Abstract

問い合わせ内容の情報が分かりにくいので整理した

  • PillSheetの日付をStringにする
  • 設定の情報は一旦reimnder timesだけに止める
    • 文字数が多いと見切れる
  • package info はkeyの名前がなくてもそれぞれ書式が違うのでわかると判断してkeyを削った
  • short version string を追加

Why

Links

Checked

  • Analyticsのログを入れたか
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた
  • リリースノートを追加した

@bannzai bannzai marked this pull request as ready for review May 30, 2022 22:24
@bannzai bannzai merged commit 433e9ab into main May 30, 2022
@bannzai bannzai deleted the enhancement/generate-debug-info branch May 30, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant