Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to takePill #633

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Rename to takePill #633

merged 1 commit into from
Jul 4, 2022

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Jul 1, 2022

Abstract

Why

ふとしたreplaceの時についでに書き変わってしまいそうで変更。RecordPageStoreのメソッドと混ざって無限ループになることを懸念

Links

Checked

  • Analyticsのログを入れたか
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた
  • リリースノートを追加した

@bannzai bannzai marked this pull request as ready for review July 4, 2022 23:16
@bannzai bannzai merged commit 035651e into main Jul 4, 2022
@bannzai bannzai deleted the rename/function/take branch July 4, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant