Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL #668

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Fix URL #668

merged 1 commit into from
Aug 26, 2022

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Aug 26, 2022

Abstract

Why

Links

Checked

  • Analyticsのログを入れたか
  • Navigator.of(context).pop() の後にContextを使用したメソッドを実行していない
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた
  • リリースノートを追加した

@bannzai bannzai marked this pull request as ready for review August 26, 2022 08:26
@bannzai bannzai merged commit fbab7b6 into main Aug 26, 2022
@bannzai bannzai deleted the bugfix/setting/link branch August 26, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant