Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upgrade flutter version #678

Merged
merged 12 commits into from
Sep 14, 2022
Merged

Fix upgrade flutter version #678

merged 12 commits into from
Sep 14, 2022

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Sep 14, 2022

Abstract

Why

Links

Checked

  • Analyticsのログを入れたか
  • Navigator.of(context).pop() の後にContextを使用したメソッドを実行していない
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた
  • リリースノートを追加した

@bannzai
Copy link
Owner Author

bannzai commented Sep 14, 2022

iOSはそのうちGitHub ActionsがXcodeの最新版を対応してくれたらビルド通るだろう。マージ

@@ -7,8 +7,8 @@ buildscript {

dependencies {
classpath 'com.google.gms:google-services:4.3.5'
classpath 'com.android.tools.build:gradle:4.1.0'
classpath 'com.google.firebase:firebase-crashlytics-gradle:2.5.0'
classpath 'com.android.tools.build:gradle:7.1.2'
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gradleのバージョンが古くてandroidのビルドが通らなかった

https://stackoverflow.com/questions/66920708/update-gradle-in-flutter-project

@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.4-all.zip
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gradleのバージョンが古くてandroidのビルドが通らなかった

https://stackoverflow.com/questions/66920708/update-gradle-in-flutter-project

classpath 'com.android.tools.build:gradle:4.1.0'
classpath 'com.google.firebase:firebase-crashlytics-gradle:2.5.0'
classpath 'com.android.tools.build:gradle:7.1.2'
classpath 'com.google.firebase:firebase-crashlytics-gradle:2.7.1'
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

古いやり方のままだけど、このページのバージョンに合わせたら動いた

https://firebase.flutter.dev/docs/crashlytics/overview/

@bannzai bannzai merged commit ce56209 into main Sep 14, 2022
@bannzai bannzai deleted the fix/setting/flutter-version branch September 14, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant