Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styleの整理 #721

Merged
merged 49 commits into from
Nov 20, 2022
Merged

Styleの整理 #721

merged 49 commits into from
Nov 20, 2022

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Nov 20, 2022 •
edited
Loading

Abstract

  • ButtonStyleの削除
  • FontTypeの削除
  • FontSizeの削除
  • TextColorStyleの削除
  • Color.primary <-> Color.secondary

Why

Links

Checked

  • Analyticsのログを入れたか
  • Navigator.of(context).pop() の後にContextを使用したメソッドを実行していない
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた
  • リリースノートを追加した

@bannzai
Remove unnecessary font
e56c608
@bannzai
Fix
3ea2a25
@bannzai
Fix
de8b629
@bannzai
Remove unnecessary named font
de3b70c
@bannzai
Replace FontType.xHugeNumber
cee0c10
@bannzai
Replace FontType.largeNumber
cb4e627
@bannzai
Replace FontType.title
4894a2d
@bannzai
Replace FontType.subTitle
2e53937
@bannzai
Replace FontType.xBigTitle
d81276d
@bannzai
Replace FontType.xBigNumber
8838e3a
@bannzai
Replace FontType.sBigTitle
8b706e7
@bannzai
Replace FontType.cardHeader
b1049e7
@bannzai
Replace FontType.thinTitle
f9dbded
@bannzai
Replace FontType.done
30122e7
@bannzai
Remove FontType.close
729e641
@bannzai
Replace FontType.componentTitle
8c0b5d9
@bannzai
Replace FontType.gridElement
f6c0970
@bannzai
Remove FontType.helpRow
eb4934b
@bannzai
Replace FontType.listRow
601ba78
@bannzai
Revert "Replace FontType.listRow"
e745caa 
This reverts commit 601ba78.
@bannzai
Replace FontType.listRow
1dfb4da
@bannzai
Replace FontType.assistingBold
32ed8b7
@bannzai
Replace FontType.assisting
9eab0c3
@bannzai
Replace FontType.inputNumber
1f1d079
@bannzai
Replace FontType.descriptionBold
ba56c3b
@bannzai
Replace FontType.description
1818ad2
@bannzai
Replace smallTitle
14a7ea4
@bannzai
Delete sSmallTitle
4782d9b
@bannzai
Delete sSmallNumber
096be98
@bannzai
Revert "Delete sSmallNumber"
a298da0 
This reverts commit 096be98.
@bannzai bannzai merged commit e0459b8 into base/refactor/app/full-scrach Nov 20, 2022
@bannzai bannzai deleted the refactor/style/scratch branch November 20, 2022 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@bannzai