Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NavigatorKey #730

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Nov 29, 2022

Abstract

navigatorKeyをglobalに持っておいて、そこからcontextを取り出すことによりrebuild後でそのWidgetのcontextが存在しない。みたいな問題を回避できることを知ったので使用する
ref: https://stackoverflow.com/questions/56280736/alertdialog-without-context-in-flutter

Why

Links

Checked

  • Analyticsのログを入れたか
  • Navigator.of(context).pop() の後にContextを使用したメソッドを実行していない
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた
  • リリースノートを追加した

@bannzai bannzai merged commit 7256ec9 into base/refactor/app/full-scrach Nov 30, 2022
@bannzai bannzai deleted the fix/navigator/navigator_key branch November 30, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant