Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #751

Merged
merged 3 commits into from
Feb 15, 2023
Merged

Bugfix #751

merged 3 commits into from
Feb 15, 2023

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Feb 14, 2023

Abstract

  • 初期設定でrequireValueしているとExceptionが発生するので修正
  • ピルシートタイプを変更した時のoffsetの計算を間違えていた

Why

Links

Checked

  • Analyticsのログを入れたか
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた

@bannzai bannzai marked this pull request as ready for review February 15, 2023 02:42
@bannzai bannzai merged commit 640b14c into main Feb 15, 2023
@bannzai bannzai deleted the bugfix/v3.17.3 branch February 15, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant