Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

解約時のモーダルを移動 #815

Merged
merged 9 commits into from
Apr 12, 2023
Merged

解約時のモーダルを移動 #815

merged 9 commits into from
Apr 12, 2023

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Apr 12, 2023

Abstract

解約時のモーダルを解約したらshouldAskCancelReason = true になるのでそれを使う

Why

Links

Checked

  • Analyticsのログを入れたか
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた

@bannzai
Copy link
Owner Author

bannzai commented Apr 12, 2023

マージしてdevでも動作確認。設定ページから解約の案内が消えていることを確認

@bannzai bannzai merged commit d512f89 into main Apr 12, 2023
@bannzai bannzai deleted the fix/modal/cancel_premium branch April 12, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant