Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

強制アップデート時のエラーハンドリングをなくす #836

Merged
merged 2 commits into from
May 4, 2023

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented May 4, 2023

Abstract

Why

強制アップデートは今必須というわけでもないので、エラーが起きてもスルーして通常のアプリを開始してもらう

Links

Checked

  • Analyticsのログを入れたか
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた

return Platform.isIOS
? "https://apps.apple.com/jp/app/id1405931017"
: "https://play.google.com/store/apps/details?id=com.mizuki.Ohashi.Pilll";
? "https://apps.apple.com/app/apple-store/id1405931017?pt=97327896&ct=force_update&mt=8"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なんとなくキャンペーンURLにしちゃったけど、よく考えるとアップデートだと機能しないかも。まあ害は無いしこのままにしよう

@bannzai bannzai merged commit d783c2a into main May 4, 2023
@bannzai bannzai deleted the fix/handling/error branch May 4, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant