Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Cadence server 0.22.3 -> 0.23.2, web 3.28.7->3.29.5 #1312

Merged
merged 11 commits into from
Dec 3, 2021

Conversation

akijakya
Copy link
Contributor

@akijakya akijakya commented Nov 25, 2021

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

Updated Cadence server 0.22.3 -> 0.23.2 and web 3.28.7->3.29.5

  • internal-only renamings
    • clusterMetaData -> clusterGroupMetaData
    • masterClusterName -> primaryClusterName
    • clusterInformation -> clusterGroup
  • internal-only config changes
    • removed obsolete publicClient config
    • restructured dynamic config
    • restructured archival config

Also fixed a wrong variable name (enableGlobalDomains -> enableGlobalDomain).

Why?

To support the latest Cadence server and web version.

Additional context

Tested with the regular chart update test.

Checklist

  • Code meets the Developer Guide
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

@akijakya akijakya self-assigned this Nov 25, 2021
@akijakya akijakya changed the title Updated cadence server 0.22.3 -> 0.23.1 Updated Cadence server 0.22.3 -> 0.23.1 Nov 25, 2021
@pregnor
Copy link
Member

pregnor commented Nov 29, 2021

@longquanzheng could you take a look when you have the time to make sure we haven't made any serious mistakes?

(It's a small/low-complexity one, just a couple config renamings.)

Copy link

@longquanzheng longquanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Also, we just released 0.23.2 today.

@pregnor
Copy link
Member

pregnor commented Dec 3, 2021

lgtm. Also, we just released 0.23.2 today.

Thanks.
Yeah, we saw it yesteday.
Either we are going to update this PR with that (and the 3.29.5 web version), retest and release together or we are gonna release a chart patch version for those server/web versions separately.

@akijakya akijakya changed the title Updated Cadence server 0.22.3 -> 0.23.1 Updated Cadence server 0.22.3 -> 0.23.2, web 3.28.7->3.29.5 Dec 3, 2021
@akijakya akijakya merged commit 4d51cb1 into master Dec 3, 2021
@akijakya akijakya deleted the release/cadence-server-0-23-1 branch December 3, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants