Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change chart cadence according v1.0.0 #1345

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ignaciogonzalezsomoza
Copy link

@ignaciogonzalezsomoza ignaciogonzalezsomoza commented Jun 29, 2023

Q A
Bug fix? no/
New feature? yes
API breaks? no
Deprecations? no
Related tickets Z
License Apache 2.0

What's in this PR?

Adapt cadence chart according to the recently released version 1.0.0. This chart has been named with the same version since it is the first jump to version 1.x.x.
The main changes affect the following elements:

  • Dynamic configuration, file type, pooling systems, retries...etc
  • Connectors, it's parameterized to include only the bootstrap of the requested services, instead of all the tchannel and grpc services, as well as configuration of the appropriate ports.
  • Cluster info: redirection policies.

Why?

new release of cadence

Checklist

  • Code meets the Developer Guide
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

@tfcace
Copy link

tfcace commented Jul 18, 2023

I suspect that enableGlobalDomain under clusterGroupMetadata in incompatible with version 1.0.0, and that the core services won't start with it included

@ramizpolic ramizpolic self-requested a review May 14, 2024 13:04
dynamicConfig:
values: {}
pollInterval: "10s"
dynamicconfig:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why the naming convention changed here? there are parts that still refer to the old snakeCase version. can we revert this to dynamicConfig before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants