Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics adapter #695

Merged
merged 6 commits into from Mar 8, 2019
Merged

Metrics adapter #695

merged 6 commits into from Mar 8, 2019

Conversation

sancyx
Copy link
Member

@sancyx sancyx commented Mar 6, 2019

No description provided.

kozmagabor
kozmagabor suggested changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@kozmagabor kozmagabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should change
{{ template "kube-metrics-adapter.fullname" . }} to {{ template "kube-metrics-adapter.name" . }} in label sections, and label selector sections

@sancyx sancyx requested a review from kozmagabor March 7, 2019 13:48
kozmagabor
kozmagabor approved these changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@kozmagabor kozmagabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@ahma ahma merged commit f48eb95 into master Mar 8, 2019
@ahma ahma deleted the metrics_adapter branch March 8, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahma ahma ahma approved these changes

@kozmagabor kozmagabor kozmagabor approved these changes

@stoader stoader stoader approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sancyx @ahma @kozmagabor @stoader