Remove finalizer when CR is in delete state without certificates #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the KafkaUser CR can come into a weird state where the CR is being deleted before it got the chance to create credentials. This fix will make sure the finalizer is being removed so the CR can be deleted.
stoader
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the KafkaUser CR can come into a weird state where the CR is
being deleted before it got the chance to create credentials. This fix
will make sure the finalizer is being removed so the CR can be deleted.
What's in this PR?
This PR will remove the finalized when the CR is in a delete state when it fails to create credentials.
Why?
Sometimes the KafkaUser CR can come into a weird state where the CR is being deleted before it got the chance to create credentials. If the delete state is a result of a namespace deletion the finalize step never happens because it tries to reconcile till the credentials are being created, but they can't be created because the namespace is being deleted.
Checklist