Removed default value from capacity.json, assigning default value for… #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
baluchicken
reviewed
Feb 2, 2022
… each broker now.
Kuvesz
force-pushed
the
capacityconfig_fix
branch
from
8826a19
to
ace4057
Compare
Kuvesz
force-pushed
the
capacityconfig_fix
branch
from
1f809e7
to
dd76980
Compare
stoader
requested changes
Feb 2, 2022
stoader
requested changes
Feb 4, 2022
stoader
requested changes
Feb 5, 2022
| result, err := json.MarshalIndent(capacityConfig, "", " ") | ||
| if err != nil { | ||
| log.Error(err, "Could not marshal cruise control capacity config") | ||
| return "", err |
There was a problem hiding this comment.
Suggested change
| return "", err | |
| return "", errors.WrapIf(err, "could not marshal cruise control capacity config") |
baluchicken
approved these changes
Feb 7, 2022
stoader
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… each broker now.
What's in this PR?
Removed default value from configmap and through that capacity.json. Now we're setting default values for every broker instead by utilizing the broker status as well as the spec. This way if something can be found in the status and not in the spec we know that that too needs (default) capacity config values assigned. This will basically mean that there will be no default config but there will be a default value for every broker which eliminates the cause of the mentioned issue.