Fix sequence of actions when new volume is added #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartam1
changed the title
stoader
reviewed
Feb 3, 2022
stoader
approved these changes
Feb 3, 2022
stoader
reviewed
Feb 3, 2022
There was a problem hiding this comment.
Perhaps a comment could be added here: https://github.com/banzaicloud/koperator/blob/master/controllers/kafkacluster_controller.go#L397 mentioning that in case of updates for PersistentVolumeClaims changes to status should never be ignored as when the status of the PVC changed as reconcile must run.
baluchicken
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
It fixes the sequence of the actions when volume addition happens.
Why?
CC Task initiated too fast in case of volume addition.
In case of a volume addition, the CC task is initiated before the volume is bounded to the pod. The rebalance indeed happened successfully but on a broker which is not aware of the new volume.
Checklist