Fix Kafka topic creation bug due to recent upgrade of AdmissionReview version #796
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
admissionv1beta1
toadmissionv1
so it matches the version with kubebuilder to avoid confusionKind
andAPIVersion
to theAdmissionReview
since they are required for "admission.k8s.io/v1" requests, reference: https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#webhook-request-and-responseWhy?
Kind
andAPIVersion
are not required for "admission.k8s.io/v1beta1" requests but required for "admission.k8s.io/v1", without the necessary fields, the API server rejects the requests with an InternalError, for example:Additional context
In #789 we upgraded the AdmissionReview from v1beta1 to v1, which causes the topic creation to fail. With the fix, kafka topics are created successfully
Checklist