Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support client IP filtering through loadBalancerSourceRanges in case istioingress #835

Merged
merged 6 commits into from Jul 15, 2022
Merged

Support client IP filtering through loadBalancerSourceRanges in case istioingress #835

merged 6 commits into from Jul 15, 2022

Conversation

stoader
Copy link
Member

@stoader stoader commented Jul 15, 2022

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
License Apache 2.0

What's in this PR?

Support client IP filtering through LoadBalancer by allowing users to specify the loadBalancerSourceRanges field for the corresponding Kubernetes service when Kafka external listeners use istioingress as ingress controller.

Why?

koperator doesn't support client IP filtering for Kafka external listeners when those are exposed through istioingress ingress controller. Currently this is only supported when envoy is used and ingress controller.

Additional context

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)

@stoader stoader requested a review from a team as a code owner July 15, 2022 08:30
pregnor
pregnor previously approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@pregnor pregnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a suggestion on phrasing

api/v1beta1/kafkacluster_types.go Outdated Show resolved Hide resolved
api/v1beta1/kafkacluster_types.go Outdated Show resolved Hide resolved
@stoader @pregnor
Update api/v1beta1/kafkacluster_types.go
2b11ee9 
Co-authored-by: Patrik Egyed <8093632+pregnor@users.noreply.github.com>
@stoader @pregnor
Update api/v1beta1/kafkacluster_types.go
7cc3d44 
Co-authored-by: Patrik Egyed <8093632+pregnor@users.noreply.github.com>
pregnor
pregnor reviewed Jul 15, 2022
View reviewed changes
Copy link
Member

@pregnor pregnor left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should sync the CRDs and samples with the new type description through manifest generation.
(Due to the comment change.)

pregnor
pregnor previously approved these changes Jul 15, 2022
View reviewed changes
panyuenlau
panyuenlau approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@panyuenlau panyuenlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this!

@stoader stoader merged commit f9bc00d into master Jul 15, 2022
@stoader stoader deleted the cidr_filtering branch July 15, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pregnor pregnor pregnor approved these changes

@panyuenlau panyuenlau panyuenlau approved these changes

@bartam1 bartam1 bartam1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stoader @pregnor @panyuenlau @bartam1