Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example kafkaCluster SSL docs #845

Merged
merged 4 commits into from Aug 15, 2022
Merged

Fix example kafkaCluster SSL docs #845

merged 4 commits into from Aug 15, 2022

Conversation

bartam1
Copy link
Contributor

@bartam1 bartam1 commented Aug 2, 2022

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
Related tickets fixes #834
License Apache 2.0

What's in this PR?

It makes up to date the usage of the sslSecrets's fields

Why?

The current documentation is deprecated

@bartam1 bartam1 requested a review from a team as a code owner August 2, 2022 12:24
stoader
stoader previously approved these changes Aug 2, 2022
pregnor
pregnor previously approved these changes Aug 2, 2022
Copy link
Member

@pregnor pregnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kuvesz
Kuvesz previously approved these changes Aug 2, 2022
@bartam1 bartam1 dismissed stale reviews from Kuvesz, pregnor, and stoader via dd7127f August 2, 2022 14:34
pregnor
pregnor previously approved these changes Aug 11, 2022
Copy link
Member

@pregnor pregnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartam1 bartam1 merged commit 98df9b3 into master Aug 15, 2022
@bartam1 bartam1 deleted the fixdocsSSLCustom branch August 15, 2022 10:49
bartam1 added a commit that referenced this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants